Add LocalTmpStorage for all services #17588
Conversation
rohangarg
force-pushed
the
test_dir_config
branch
from
a6f3e1e to
2864ed2
Compare
rohangarg
force-pushed
the
test_dir_config
branch
from
2864ed2 to
7888593
Compare
| @LazySingleton | ||
| public LocalTmpStorage getLocalTmpStorage() | ||
| { | ||
| File tmpDir = new File(taskDirPath, "tmp"); |
There was a problem hiding this comment.
@cheddar : should we create the temporary storage per attempt? or should we share it across attempts for re-use of temp data?
There was a problem hiding this comment.
Let's share it. The old default for cases where this would've been used is just java.io.tmpdir which was shared as well, so it shouldn't cause problems...
|
|
||
| import java.io.File; | ||
|
|
||
| public interface LocalTmpStorage |
There was a problem hiding this comment.
pretty similar to TempDirProducer ; to service this usecase maybe that could be enhanced with a lazy init and a getRoot ?
There was a problem hiding this comment.
TempDirProducer appears to have semantics around cleaning up with close(). That class is different from this class, this class is basically just a Config. It could be called a Config, but Rohan doesn't like the word config, so it got this name instead.
LocalTmpStorage is just delivering a location, nothing more, nothing less, it provides something that can be injected to get at a system-configured tmp storage location and is not intended to actually do anything beyond that. It probably deserves javadoc that describes that this class shouldn't be doing anything other than delivering configuration as it's just there to be an injectable configuration object.
It could absolutely make sense to have TempDirProducer depend on a LocalTmpStorage in order to get the tmp dir location that it's supposed to use.
| */ | ||
| File getTmpDir(); | ||
|
|
||
| class DefaultLocalTmpStorageProvider implements Provider<LocalTmpStorage> |
There was a problem hiding this comment.
doesn't seem like the system will prepare to clean up these files - wouldn't that will fill up the disk/create garabge?
There was a problem hiding this comment.
The tmpdir provided from this is just a location. Whether things are cleaned up or not is a question of the implementation. In general, most of the code that deals with tmp files cleans them up after itself and if it's not cleaning up after itself, that should either be intentional and have a design reason or it is a bug in the code that's dealing with the file, not a bug in the code that's delivering the location of the directory.
Provides an interface for getting local temporary storage in all the services. In all future changes, the users can directly inject an object of
LocalTmpStorageand use the temporary directory in it as a scratch pad.Along with the consolidation and possible ability to track all temp data in future, this also provides a common interface for interacting with all local temporary storage work.